100% test coverage #396
Merged
100% test coverage #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
===========================================
+ Coverage 99.17% 100.00% +0.82%
===========================================
Files 1 1
Lines 364 379 +15
Branches 130 136 +6
===========================================
+ Hits 361 379 +18
+ Misses 3 0 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blakeembrey
commented
Aug 7, 2025
| let value = ""; | ||
| let i = 0; | ||
|
|
||
| function name(value: string) { |
There was a problem hiding this comment.
Pulled name function out (which adds bytes) because it's needed to avoid a crash on name being missing before the token type error.
|
wesleytodd
approved these changes
Aug 18, 2025
|
Requested myself so I can find it again if I dont get to it after the tc meeting |
UlisesGascon
approved these changes
Aug 18, 2025
jonchurch
approved these changes
Aug 18, 2025
blakeembrey
force-pushed
the
be/100-code-cov
branch
from
2a3d359 to
5de5056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up 100% test coverage cases, additionally shifting some bytes around for readability and size (mainly the
.mapto aforloop to make the recursive case more obvious).